Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct top-level MPT size/alignment requirements #112

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Correct top-level MPT size/alignment requirements #112

merged 1 commit into from
Nov 20, 2024

Conversation

SiFiveHolland
Copy link
Collaborator

@SiFiveHolland SiFiveHolland commented Nov 15, 2024 •
edited
Loading

Closes #111

  • The first sentence is wrong because the type of table depends on the mode (even if the PAW is larger or smaller).
  • The sizes given are wrong for Smmpt34, because in that case each entry is 4 bytes, not 8.
  • The minimum alignment (irrespective of table size) is 4 KiB because that is the number of low bits omitted from the PPN.

@rsahita rsahita mentioned this pull request Nov 18, 2024
Closed
rsahita
rsahita reviewed Nov 18, 2024
View reviewed changes
chapter3.adoc Show resolved Hide resolved
rsahita
rsahita approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@rsahita rsahita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsahita rsahita merged commit c9a5d28 into riscv:main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsahita rsahita rsahita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should the mptl3.ppn be aligned with the mpt table size (16MB)?
2 participants
@SiFiveHolland @rsahita