zilsd/zcmlsd Support #490
Draft
zilsd/zcmlsd Support #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timmmm
reviewed
May 28, 2024
c_emulator/riscv_sim.c
Outdated
| @@ -141,6 +141,8 @@ static struct option options[] = { | |||
| {"trace-output", required_argument, 0, OPT_TRACE_OUTPUT }, | |||
| {"inst-limit", required_argument, 0, 'l' }, | |||
| {"enable-zfinx", no_argument, 0, 'x' }, | |||
| {"enable-zilsd", no_argument, 0, 'y' }, | |||
There was a problem hiding this comment.
Can you use long options like OPT_ENABLE_WRITABLE_FIOM?
model/riscv_insts_base.sail
Outdated
| @@ -43,6 +43,7 @@ | |||
| /* (ERC) under the European Union’s Horizon 2020 research and innovation */ | |||
| /* programme (grant agreement 789108, ELVER). */ | |||
| /* */ | |||
| /* Modified by NXP on 02/02/2024 */ | |||
There was a problem hiding this comment.
This seems to be based on an older commit - can you rebase on master?
model/riscv_insts_base.sail
Outdated
| signed loads also present for widths equal to xlen_bytes */ | ||
| /* for Zilsd unsigned loads are only present for widths strictly less than xlen_bytes*2, | ||
| signed loads also present for widths equal to xlen_bytes*2 */ | ||
| mapping clause encdec = LOAD(imm, rs1, rd, is_unsigned, size, false, false) if (word_width_bytes(size) < sizeof(xlen_bytes)) | (not(is_unsigned) & word_width_bytes(size) <= sizeof(xlen_bytes)) | (haveZilsd() & (word_width_bytes(size) < sizeof(xlen_bytes)*2) | (not_bool(is_unsigned) & word_width_bytes(size) <= sizeof(xlen_bytes)*2)) |
There was a problem hiding this comment.
This guard clause is crazy long now. Probably worth moving to a function?
model/riscv_insts_base.sail
Outdated
|
|
||
| val extend_value : forall 'n, 0 < 'n <= xlen_bytes. (bool, MemoryOpResult(bits(8 * 'n))) -> MemoryOpResult(xlenbits) | ||
| function extend_value(is_unsigned, value) = match (value) { | ||
| MemValue(v) => MemValue(if is_unsigned then zero_extend(v) else sign_extend(v) : xlenbits), | ||
| MemException(e) => MemException(e) | ||
| } | ||
|
|
||
| val extend_value_pair : forall 'n, 0 < 'n <= xlen_bytes*2. (bool, MemoryOpResult(bits(8 * 'n))) -> MemoryOpResult(xlenbits_double) |
There was a problem hiding this comment.
I think this is all going to conflict fairly heavily with #477 unfortunately.
Timmmm
pushed a commit
to Timmmm/sail-riscv
that referenced
this pull request
Oct 2, 2024
debug: flushregs -> maintenance flush register-cache
…sd specification generated from ADL.
…sd specification generated from ADL.
…sd specification generated from ADL.
…sd specification generated from ADL.
…sd specification generated from ADL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for not yet ratified zilsd/zcmlsd extension
In c_emulator, the following options are added:
-y to enable zilsd extension
-Z to enable zcmlsd extension
In ocaml emulator the following options are added:
-enable-zilsd to enable zilsd extension
-enable-zcmlsd to enable zcmlsd extension
All options are false by default.
The tests were split in Zilsd and Zcmlsd folders because different simulation options are required to run the tests.