Use newtypes for register indices and numbers #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required splitting many of the AST constructors.
Zicsr instructions can take an immediate or a register index for their source operand. Don't pun in the AST using a boolean to distinguish, and instead use two constructors in the AST scattered union.
nwf
force-pushed
the
202411-newtype_regidx
branch
from
a5d9770
to
97a7742
Compare
arichardson
reviewed
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for more seriously tackling #523. This PR...
regidxandregnoto benewtypesand updates all use sites appropriately.vregidxfromregidx(and friends) for Vector (vext) registers, which, AFAIK, are a completely separate set of 32 registers.fregidxfromregidx(and friends) for F/D/Zcd/Zcf/Zfa/Zfh and V (again) extensions. There's a little muss and fuss around the definition to do withZfinx, but otherwise it's also pretty rote.CSRastctor intoCSRImmandCSRReg.This was a slog. Most of the changes can be described as "type-directed" and "mechanical" but were all done... er, artisanally, so some more careful review is probably merited. Perhaps best viewed with word diff, not line diff.
The curious are welcome to look at https://github.com/nwf/sail-riscv/tree/202411-eext to see how I think we can properly support E atop this base, and indeed, most of these changes were motivated or directed by that work, but I would like to get this reviewed independently of that shuffling and further refactoring.