-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add error handling for Bytecode type #379
refactor: add error handling for Bytecode type #379
Conversation
\cc @hai-rise |
Seem the tests is falling, I will try to fix asap @hai-rise |
@TropicalDog17 Yes, conversions in the main library must also handle the new |
Hi @hai-rise, seems CI is passing now, can you take a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments. Some parts can be quite confusing. We should definitely improve error handling going forward; or really inline an EVM implementation to avoid these REVM conversions altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More nits 🙏.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience! Hopefully, #382 will also remove most of these complications in the future.
Fixes #378