Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): fix bug and add test for retry method #3

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(utils): fix bug and add test for retry method #3

merged 1 commit into from
Jul 29, 2024

Conversation

wjf3121
Copy link
Contributor

@wjf3121 wjf3121 commented Jul 27, 2024 •
edited
Loading

  • Retry times was 1 more than the expected ones, fixed the issue.
  • Add unit test for the method.
  • Fix Makefile rule and gitignore for running unit tests.

@wjf3121 wjf3121 requested a review from lukeraphael July 27, 2024 12:13
@wjf3121 wjf3121 force-pushed the junfeng/util-test branch 2 times, most recently from 5d9fb38 to f1042e1 Compare July 27, 2024 12:22
lukeraphael
lukeraphael approved these changes Jul 29, 2024
View reviewed changes
Copy link

@lukeraphael lukeraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjf3121 wjf3121 added this pull request to the merge queue Jul 29, 2024
@wjf3121 wjf3121 removed this pull request from the merge queue due to a manual request Jul 29, 2024
@wjf3121 wjf3121 force-pushed the junfeng/util-test branch from f1042e1 to d79983e Compare July 29, 2024 07:21
@wjf3121 wjf3121 enabled auto-merge July 29, 2024 07:22
@wjf3121 wjf3121 added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit 837fed0 Jul 29, 2024
2 checks passed
@wjf3121 wjf3121 deleted the junfeng/util-test branch July 29, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeraphael lukeraphael lukeraphael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjf3121 @lukeraphael