Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdc): fix wrong default column matching #20348

Merged
merged 7 commits into from
Feb 5, 2025
Merged

fix(cdc): fix wrong default column matching #20348

merged 7 commits into from
Feb 5, 2025
+45 −12

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Jan 31, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix the bug introduced in #19354. Resolve #20346
The bug will cause two problems:

  1. Differences in the orders of rw schema and pg schema can lead to wrong default value assigned.
  2. Due to zip_eq_fast, if the numbers of columns in rw schema and pg schema are different, panic happens.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/fix Bug fix label Jan 31, 2025
@KeXiangWang KeXiangWang requested review from hzxa21 and st1page January 31, 2025 00:50
BugenZhao
BugenZhao reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/frontend/src/handler/create_table.rs Outdated Show resolved Hide resolved
@KeXiangWang KeXiangWang mentioned this pull request Feb 1, 2025
Merged
9 tasks
@KeXiangWang KeXiangWang force-pushed the wkx/fix-column-mismatch branch from ceb7735 to 036285d Compare February 5, 2025 00:25
@KeXiangWang KeXiangWang requested a review from BugenZhao February 5, 2025 00:27
@KeXiangWang KeXiangWang enabled auto-merge February 5, 2025 03:33
@KeXiangWang KeXiangWang added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@KeXiangWang KeXiangWang added this pull request to the merge queue Feb 5, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
@KeXiangWang
fix(cdc): fix wrong default column matching (#20348)
d1eccfb
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@KeXiangWang KeXiangWang added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 5797829 Feb 5, 2025
38 of 39 checks passed
@KeXiangWang KeXiangWang deleted the wkx/fix-column-mismatch branch February 5, 2025 14:59
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@KeXiangWang
fix(cdc): fix wrong default column matching (#20348)
02a89fc
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@KeXiangWang
fix(cdc): fix wrong default column matching (#20348)
8bb17e7
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2025
@github-actions @KeXiangWang
@cyliu0 @st1page
fix(cdc): fix wrong default column matching (#20348) (#20397)
b026af1 
Co-authored-by: Kexiang Wang <[email protected]>
Co-authored-by: Chengyou Liu <[email protected]>
Co-authored-by: stonepage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@st1page st1page st1page approved these changes

@yuhao-su yuhao-su Awaiting requested review from yuhao-su

@hzxa21 hzxa21 Awaiting requested review from hzxa21

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

Assignees
No one assigned
Labels
need-cherry-pick-release-2.1 need-cherry-pick-release-2.2 priority/critical type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postgres_cdc: fails miserably when there are less columns in RW table than in PG source table
4 participants
@KeXiangWang @fuyufjh @BugenZhao @st1page