Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project: update usage of ios to apple #36

Merged
merged 3 commits into from
Feb 14, 2025
Merged

project: update usage of ios to apple #36

merged 3 commits into from
Feb 14, 2025

Conversation

dskuza
Copy link
Collaborator

@dskuza dskuza commented Feb 12, 2025 •
edited
Loading

  • Renames the ios-macos directory to apple
  • Adds redirects for the main Apple page
  • Adds wildcard redirects for all remaining Apple pages
  • First pass at replacing all usage of "iOS" with "Apple platforms"

@dskuza dskuza requested a review from a team as a code owner February 12, 2025 23:22
HayesGordon
HayesGordon reviewed Feb 13, 2025
View reviewed changes
runtimes/choose-a-renderer/overview.mdx Outdated
- **Android**: `Skia` (default), `Rive`, and `Canvas`

In the future, `Rive` will be the default for both iOS and Android.
In the future, `Rive` will be the default for both Apple platforms and Android.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that we should make updates to the docs once Android drops skia

@HayesGordon
Copy link
Contributor

Looks good! I left some comments that I think needs to be addressed before merging.

Another general comment is that in some places, we say "Apple platform runtime" and in others, just "Apple runtime". When do we use one over the other?

@dskuza
Copy link
Collaborator Author

dskuza commented Feb 13, 2025

@HayesGordon Updated! Re: platforms vs runtimes - maybe platforms is the wrong word, and devices is better. However, that should only be if we're talking about device support, otherwise, it should be runtimes. At least, that's my initial thought. Good callout.

@dskuza dskuza force-pushed the update-ios-to-apple branch from c71fa1e to c2b8a90 Compare February 14, 2025 15:15
HayesGordon
HayesGordon approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dskuza dskuza force-pushed the update-ios-to-apple branch from c2b8a90 to 886a611 Compare February 14, 2025 19:18
@dskuza dskuza merged commit a0ba150 into main Feb 14, 2025
2 checks passed
@dskuza dskuza deleted the update-ios-to-apple branch February 14, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lancesnider lancesnider lancesnider approved these changes

@HayesGordon HayesGordon HayesGordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dskuza @HayesGordon @lancesnider