Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce conventional commits #563

Merged
merged 1 commit into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: Run Battery of Checks for Backend
name: Linting and Testing

on: [push, pull_request]
on:
pull_request:
branches: [ main ]

jobs:
battery:
Expand Down Expand Up @@ -32,19 +34,19 @@ jobs:
pip install poetry
poetry install --no-root --with dev

# - name: Ruff & Isort Check
# run: |
# poetry run ruff check ./src
# poetry run isort --check-only ./src
- name: Ruff & Isort Check
run: |
poetry run ruff check ./src
poetry run isort --check-only ./src

# - name: Type check
# run: poetry run pyright
- name: Type check
run: poetry run pyright

# - name: Run Tests & Coverage
# run: poetry run pytest --cov=./src --cov-report=xml
- name: Run Tests & Coverage
run: poetry run pytest --cov=./src --cov-report=xml

# - name: Upload Coverage Report to Codecov
# uses: codecov/[email protected]
# with:
# token: ${{ secrets.CODECOV_TOKEN }}
# file: ./coverage.xml
- name: Upload Coverage Report to Codecov
uses: codecov/[email protected]
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage.xml
16 changes: 16 additions & 0 deletions .github/workflows/conventional-commits.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Conventional Commits

on:
pull_request:
branches: [ main ]

jobs:
build:
name: Conventional Commits
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: webiny/[email protected]
#with:
#GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Optional, for private repositories.
#allowed-commit-types: "feat,fix," # Optional, set if you want a subset of commit types to be allowed.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ We welcome contributions from the community! To ensure a smooth collaboration, p
### Submitting Changes

1. **Open an Issue**: For major changes, start by opening an issue to discuss your proposed modifications. This helps us understand your intentions and provide feedback early in the process.
2. **Pull Requests**: Once your changes are ready, submit a pull request. Ensure your code adheres to our coding standards and passes all tests.
2. **Pull Requests**: Once your changes are ready, submit a pull request. Ensure your code adheres to our coding standards and passes all tests. Commits should follow [conventional-commits](https://www.conventionalcommits.org/) specification.

### Code Formatting

Expand Down
Loading