Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add retry policy and connection pool configuration to request utils #864

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: add retry policy and connection pool configuration to request utils #864

merged 1 commit into from
Nov 5, 2024

Conversation

iPromKnight
Copy link
Collaborator

@iPromKnight iPromKnight commented Nov 5, 2024 •
edited by coderabbitai bot
Loading

  • Introduced retry policy and connection pool configuration in create_service_session.
  • Added get_retry_policy and get_http_adapter functions for customizable retry and connection settings.
  • Updated tests to cover new session adapter configurations and ensure correct behavior.

Summary by CodeRabbit

  • New Features

    • Enhanced request handling with support for retry policies and custom HTTP adapters.
    • Improved error handling for various HTTP status codes.
    • New utility functions for creating retry policies and HTTP adapters.

  • Bug Fixes

    • Improved session configuration flexibility and error management.

  • Tests

    • Added new test cases and fixtures for rate limiting and session configurations.

@iPromKnight
fix: add retry policy and connection pool configuration to request utils
7d8ae50 
- Introduced retry policy and connection pool configuration in `create_service_session`.
- Added `get_retry_policy` and `get_http_adapter` functions for customizable retry and connection settings.
- Updated tests to cover new session adapter configurations and ensure correct behavior.
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance the request handling and response parsing capabilities within the src/program/utils/request.py file. Key updates include the introduction of retry policies and custom HTTP adapters, modifications to the BaseRequestHandler and create_service_session functions to accept new parameters, and improvements in error handling for various HTTP status codes. Additionally, new utility functions for creating retry policies and HTTP adapters have been added. The test suite in src/tests/test_rate_limiting.py has also been updated with new fixtures and tests to validate these enhancements.

Changes

File Change Summary
src/program/utils/request.py - Updated BaseRequestHandler constructor to accept additional parameters (custom exceptions, request logging).
- Modified create_service_session to include session_adapter and retry_policy.
- Added methods: get_retry_policy, get_http_adapter, _create_and_mount_session_adapter.
- Enhanced ResponseObject and handle_response for better error handling.
src/tests/test_rate_limiting.py - Added fixtures for retry_policy and connection_pool_params.
- Introduced tests: test_session_adapter_configuration and test_session_adapter_pool_configuration_and_request to validate session adapter configurations and behavior.

Possibly related PRs

  • feat: add rate limiting tests and update dependencies #857: The changes in this PR enhance the BaseRequestHandler to manage rate limit exceptions and update the create_service_session function to accommodate additional parameters related to rate limits, which directly relates to the modifications made in the main PR regarding session handling and error management for rate limits.

Suggested reviewers

  • Gaisberg

🐇 In the meadow, I hop with glee,
New features added, oh what a spree!
With retries and adapters, we dance and play,
Improving our requests in a splendid way!
So let’s celebrate this code so bright,
A joyful leap in the moonlight! 🌙✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@iPromKnight iPromKnight merged commit 1713a51 into main Nov 5, 2024
1 of 2 checks passed
@iPromKnight iPromKnight deleted the hotfix/connection_pools branch November 5, 2024 22:54
@dreulavelle dreulavelle mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iPromKnight