-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): release 0.20.0 #897
Conversation
WalkthroughThe pull request introduces version 0.20.0 of the project, updating the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
pyproject.toml (2)
Line range hint
77-77
: Consider cleaning up commented dependencyThe commented out
memray
dependency might be needed for memory profiling. Consider either:
- Removing it if it's no longer needed
- Uncommenting it if memory profiling is required
- Adding a comment explaining why it's commented out
Update regex package to the latest version (2024.11.6)
The regex package has a newer version available (2024.11.6) compared to the current version (2023.12.25) being used. Since this dependency is critical for adult content parsing improvements, updating to the latest version is recommended. The requests-cache package is already using the latest version (1.2.1).
No security vulnerabilities were found for either package.
🔗 Analysis chain
Line range hint
21-21
: Verify regex and requests-cache versionsThe regex package version (^2023.12.25) is from December 2023. Given that this dependency is likely critical for the adult content parsing improvements, we should verify if a newer version is available.
Also applies to: 47-47
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check latest versions and potential issues for both packages echo "Checking latest versions from PyPI..." for pkg in "regex" "requests-cache"; do echo "Package: $pkg" curl -s "https://pypi.org/pypi/$pkg/json" | jq -r '.info.version' done echo -e "\nChecking for security advisories..." for pkg in "regex" "requests-cache"; do echo "Package: $pkg" gh api graphql -f query='{ securityVulnerabilities(first:5, ecosystem:PIP, package:"'$pkg'") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange } } }' doneLength of output: 1282
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
CHANGELOG.md
(1 hunks)pyproject.toml
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- CHANGELOG.md
🔇 Additional comments (2)
pyproject.toml (2)
3-3
: LGTM: Version bump aligns with release objectives
The version bump to 0.20.0 correctly reflects the new feature additions mentioned in the PR objectives.
Line range hint 1-88
: Verify dependencies for new features
Given the new features (denied reasoning for torrents and adult content parsing), let's verify if all required dependencies are present.
✅ Verification successful
Let me check the actual implementation details to verify if the existing dependencies are sufficient for these features.
Let me check one more thing about the RTN package since it seems to be handling the core functionality.
Based on the analysis of the codebase and dependencies, I can now provide the final response:
Dependencies are sufficient for the new features
The codebase already includes all necessary dependencies for the new features:
- Adult content parsing and denial reasoning are handled through the
rank-torrent-name
(RTN) package (version >=1.5) - Core functionality is integrated through RTN's
ParsedData
,Torrent
, andGarbageTorrent
components - Standard library components and existing dependencies (typing, logging) support the implementation
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for relevant imports in the codebase that might be used for these features
echo "Searching for adult content parsing related imports..."
rg -l "import.*(?:adult|parse|content)" --type py
echo -e "\nSearching for torrent denial reasoning related imports..."
rg -l "import.*(?:torrent|deny|trash)" --type py
Length of output: 642
Script:
#!/bin/bash
# Check implementation details of files that might use these features
echo "Checking adult content parsing implementation..."
rg -A 5 "(?i)adult.*content|parse.*adult" --type py
echo -e "\nChecking denial reasoning implementation..."
rg -A 5 "(?i)deny.*reason|trash.*reason|torrent.*reject" --type py
echo -e "\nChecking imports in these specific files..."
cat src/program/services/scrapers/shared.py src/program/services/downloaders/shared.py | rg "^import|^from.*import"
Length of output: 1263
Script:
#!/bin/bash
# Check RTN package version and requirements
echo "Checking RTN package in dependencies..."
grep -A 1 "rank-torrent-name" pyproject.toml
echo -e "\nChecking RTN usage for adult content and denial..."
rg -A 5 "RTN.*(?:adult|deny|reject|trash)" --type py
Length of output: 361
🤖 Created releases:
|
🤖 I have created a release beep boop
0.20.0 (2024-11-20)
Features
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation