Add JobCleaner timeout dynamically #576
Conversation
|
@PumpkinSeed thanks for taking a stab at this! I think we will end up needing to add some test coverage for it, but otherwise it looks pretty much spot on. Could you please add yourself to the CLA here before we move forward on this? https://github.com/riverqueue/rivercla |
|
@bgentry I wrote a specific test for this case. I already did the CLA in the past. |
|
D’oh, sorry I missed that 🤦🏼♂️ newborn sleep deprivation kicking in over here 😅 Will sync with @brandur on this shortly and hopefully get it merged, thank you! |
|
Hi, do you have any update on this? @bgentry |
|
Hi @PumpkinSeed, really sorry about the delay on this. I should be able to get it merged today and shipped in the next release. |
bgentry
force-pushed
the
I575-jobcleaner-deadline
branch
from
8a5118b
to
ab57b0f
Compare
|
@brandur I did some cleanup on this one and I think it should be suitable for now, but please feel free to take a look before it ships! |
An infinitesimal change to add a missing pull request link for the change in #576.
An infinitesimal change to add a missing pull request link for the change in #576.
Suggested implementation of #575