-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert i
commands to rzshell
#1238
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few code style nitpicks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Regarding:
I think it's necessary to print empty values still, for the sake of parsers of JSON output
|
8de406b
to
7eee2a4
Compare
file.analyze cfg var does not even exist
This comment has been minimized.
This comment has been minimized.
Please ignore the failing tests for now. Just look at the output and see if the changes make sense. It is just a matter of updating tests to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new output 👍
i
commands to the newshelli
commands to rzshell
Your checklist for this pull request
Detailed description
Convert
i
commands to rzshell. In the process, move most of the output to RzTable for consistency.Test plan
CI green + a lot of manual testing to ensure stuff still works and are displayed well.
Make sure the issues listed below were really addressed:
iHH
should be killed in profit ofiH
only. #1516Not done here.izzz
reports wrong addresses #1514izzz
code is quite messy and would need a separate PR.ConvertNot done here. It will be done in a separate PR due to this involving opening a new rzbinfile and operating on that. Might be tricky because API is still not awesome.i
/rz-bin
calls inside Rizin to the API calls #1475i
commands to newshell #786ib
command #1120Closing issues
Closes #1516
Closes #786
Closes #1120
Closes #1027