Convert pm to rz-shell
#1686
Merged
Convert pm to rz-shell
#1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
officialcjunior
force-pushed
the
rzshell-pm
branch
from
cbc9c9f to
f7893b1
Compare
officialcjunior
requested review from
kazarmy,
ret2libc,
thestr4ng3r,
wargio and
XVilka
as code owners
XVilka
reviewed
Sep 23, 2021
ret2libc
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Converts
pm(print magic command) to rz-shell/newshell.Test plan
pmalready has multiple tests and I added a test forpmj.Also needs to figure out what to do with some extra information that was getting printed as help: https://github.com/rizinorg/rizin/blob/dev/librz/core/cmd_magic.c#L197
Closing issues
Related to #1342 and #1590