Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port r (resize) commands to the rzshell #1737

Merged
merged 2 commits into from
Sep 26, 2021
Merged

Port r (resize) commands to the rzshell #1737

merged 2 commits into from
Sep 26, 2021

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Sep 23, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

  • Migrate r (resize) commands to the rzshell
  • Removed rizin, rz-bin, etc commands to call tools from inside the Rizin
  • Removed reset command to reset the terminal (Not sure about usability of such command, let me know if I should return it)
  • Removed rm $<name> command to remove alias, since I think it's better to have it in the $ command, let me know if I should restore it.

Test plan

CI is green

Partially addresses #1342

Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just minor stuff

@ret2libc ret2libc enabled auto-merge (rebase) September 26, 2021 16:20
@ret2libc ret2libc merged commit 5844691 into dev Sep 26, 2021
@ret2libc ret2libc deleted the asan-resize-newshell branch August 5, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants