Port search commands (`/`) to newshell#2212

Closed

DMaroo wants to merge 34 commits intodevfrom port-search

+1,320-3,871

Commits on Dec 11, 2022

Add rz_str_extract_printable util function
DMaroo
committed
Start porting search commands (/) to newshell
DMaroo
committed
Use RZ_STR_DUP macro instead of rz_str_newf
DMaroo
committed
Rename eprintf to RZ_LOG_ERROR
DMaroo
committed
Assign correct values to param members
DMaroo
committed
Add UPDATE_LASTSEARCH macro
DMaroo
committed
Open and end the JSON object appropriately
DMaroo
committed
Fixed search_kw null handling
DMaroo
committed
Rearrange functions and remove "currently" unused functions
DMaroo
committed
Change according to review
DMaroo
committed
Add RZ_NONNULL decoration for function arguments in str.c
DMaroo
committed
Format according to clang-format
DMaroo
committed
Fix segfault and remove unnecessary RZ_LOG_ERROR
DMaroo
committed
Add details for cx command regarding ignoring bytes while comparing
DMaroo
committed
Port /x search commands; Fix JSON printing
DMaroo
committed
Implement command handler for /a
DMaroo
committed
Add RzSearchParams struct
DMaroo
committed
Add new and free functions for RzSearchParams
DMaroo
committed
Remove RzCore from rz_search.h
DMaroo
committed
Fix the logic in rz_str_extract_printable
DMaroo
committed
Use RZ_LOG_INFO instead of rz_cons_printf
DMaroo
committed
Change details for cx
DMaroo
committed
Remove rz_core_search_params_new; Use rz_search_params_new instead
DMaroo
committed
Add unit test for rz_str_extract_printable
DMaroo
committed
Replace rz_search_set_distance and rz_search_kw_add with their RzSearchParams counterpart
DMaroo
committed
Initialize search parameters in rz_core_init
DMaroo
committed
Add ownership annotation for rz_search_new
DMaroo
committed
Format according to clang-format
DMaroo
committed
Replace rz_search_string_prepare_backward with RzSearchParams variant
DMaroo
committed
Use RzSearchParam callback in rz_search_find if it exists
DMaroo
committed
Removed unused duplicate function rz_search_update_i
DMaroo
committed
Replace eprintf; Fix code typos
DMaroo
committed
Remove unused functions rz_search_find, listcb
DMaroo
committed
Fix merge conflict remnants
DMaroo
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port search commands (`/`) to newshell#2212

Commits on Dec 11, 2022

Add `rz_str_extract_printable` util function

Start porting search commands (`/`) to newshell

Use `RZ_STR_DUP` macro instead of `rz_str_newf`

Rename `eprintf` to `RZ_LOG_ERROR`

Assign correct values to `param` members

Add `UPDATE_LASTSEARCH` macro

Open and end the JSON object appropriately

Fixed `search_kw` null handling

Rearrange functions and remove "currently" unused functions

Change according to review

Add `RZ_NONNULL` decoration for function arguments in `str.c`

Format according to clang-format

Fix segfault and remove unnecessary RZ_LOG_ERROR

Add details for `cx` command regarding ignoring bytes while comparing

Port `/x` search commands; Fix JSON printing

Implement command handler for `/a`

Add `RzSearchParams` struct

Add new and free functions for `RzSearchParams`

Remove `RzCore` from `rz_search.h`

Fix the logic in `rz_str_extract_printable`

Use `RZ_LOG_INFO` instead of `rz_cons_printf`

Change details for `cx`

Remove `rz_core_search_params_new`; Use `rz_search_params_new` instead

Add unit test for `rz_str_extract_printable`

Replace `rz_search_set_distance` and `rz_search_kw_add` with their `RzSearchParams` counterpart

Initialize search parameters in `rz_core_init`

Add ownership annotation for `rz_search_new`

Format according to clang-format

Replace `rz_search_string_prepare_backward` with `RzSearchParams` variant

Use `RzSearchParam` callback in `rz_search_find` if it exists

Removed unused duplicate function `rz_search_update_i`

Replace `eprintf`; Fix code typos

Remove unused functions `rz_search_find`, `listcb`

Fix merge conflict remnants