Convert rz-bin cmd call in rz-find to API

[chinggg]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
• I've added tests that prove my fix is effective or that my feature works (if possible)
• I've updated the rizin book with the relevant information (if needed)

Detailed description

• Convert rz-bin -qzzz call in case RZ_SEARCH_STRING to internal API
  • https://github.com/rizinorg/rizin/blob/dev/librz/main/rz-bin.c#L1189
• RZ_SEARCH_MAGIC
• RZ_SEARCH_ESIL
  ...

Test plan

...

Closing issues

closes #1475
...

[ret2libc]

How is state used here? Also, is it really necessary to have core?

[chinggg]

How is state used here? Also, is it really necessary to have core?

You are right, state is not used since the output mode is specified by bf->strmode.

If RzCore is not used, more code is needed to make RzBin work, which do you prefer?

RzBin *bin = rz_bin_new();
RzIO *rio = rz_io_new();
rio->cb_printf = rz_cons_printf;
rz_io_bind(rio, &bin->iob);
// ..
rz_bin_free(bin);
rz_io_free(rio);

[wargio]

you can just printf without rz_cons

[ret2libc]

Thanks!

Damn, rz_bin_dump_strings API is really bad...

[chinggg]

Yes. In fact I think sometimes it is more convenient to use command especially if the API is not well-designed.
For the other usage of rz_sys_cmdf in the same function rzfind_open_file, should it be replaced by internal API?

[wargio]

Thanks!

Damn, rz_bin_dump_strings API is really bad...

i will remove it in one of my PRs on RzPrint