Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert dd commands to rzshell #3049

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Convert dd commands to rzshell #3049

merged 1 commit into from
Sep 29, 2022

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Sep 28, 2022 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Convert dd command to rzshell
  • Listing descriptors moved from dd to ddl
  • Added JSON and table modes to ddl
  • Remove unimplemented dH command
  • Remove ddt command
  • Move date command to the "shell" category

Test plan

  • CI is green
  • Try dd commands
  • Try the date command

Closing issues

Partially addresses #1342

ret2libc
ret2libc approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved except what mentioned by @wargio .

@XVilka
Convert dd commands to rzshell
e5e3df2 
* Convert `dd` command to rzshell
* Remove unimplemented `dH` command
* Remove `ddt` command
* Move `date` command to the "shell" category
@XVilka XVilka merged commit 4bf6b67 into dev Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

@wargio wargio wargio approved these changes

@yossizap yossizap Awaiting requested review from yossizap yossizap is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
merge-when-green refactor Refactoring requests rz-test RzCore RzDebug shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XVilka @wargio @ret2libc