Convert pv commands to rzshell
#3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
reviewed
Oct 7, 2022
This comment was marked as resolved.
This comment was marked as resolved.
ret2libc
requested changes
Oct 7, 2022
Comment on lines
+6456
to
+6491
| ut8 *block = core->block; | ||
| int blocksize = core->blocksize; | ||
| ut8 *block_end = core->block + blocksize; | ||
|
|
||
| if (block + 8 >= block_end) { | ||
| RZ_LOG_ERROR("core: block is truncated.\n"); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I think the block concept can be removed and we can use rz_io_nread_at instead. In any case, we can probably avoid the rz_core_seek in the do/while loop below and just keep track of at manually (you can use ps @ {addr} in the print_value_single function).
There was a problem hiding this comment.
I would prefer to postpone this until converting to the API calls, after ps are converted to the rzshell and a better API.
ret2libc
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
pvcommands to rzshellpVcommands that are same aspvbut withuseBytes == true. No tests exists for thosepvzcommands as undocumented and untestedTest plan
CI is green
Closing issues
Partially solves #1590