Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert de commands to the rzshell #3083

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Convert de commands to the rzshell #3083

merged 1 commit into from
Oct 10, 2022

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Oct 9, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Converted de commands to rzshell
  • Listing is done now with del instead of de, added JSON and TABLE outputs
  • Moved some code from librz/debug/desil.c to librz/core/cesil.c

Please don't spend too much time reviewing ESIL parts of the code since we will remove them some time in the future anyway: #2080

Test plan

CI is green

Closing issues

Partially addresses #1342

@XVilka XVilka merged commit 87e369b into dev Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants