Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pCd missing instruction is fixed. #3431

Closed

Conversation

Codesbyusman
Copy link

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

For details see the issue 3318

The pCd command is missing some instructions when the user inputs specific rows to be shown. However, the instructions are actually present, as discussed in this issue 3213. Upon further analysis, it was discovered that the instruction at the initial point caused the first column to have ten rows but miss one instruction row. To address this issue, I changed the canvas size so that it can fit the missing instruction.

image

I am new to Rizin and I am open to exploring other solutions if this one is not good enough.

Test plan

None

Closing issues

closes #3318

@Codesbyusman
Copy link
Author

added a test in test\db\cmd\cmd_p_capital_c as I tried but was unable to track how the instructions are written in the test file thus added a dummy line which passes the test but would like to know the actual instruction that will come there.

@ret2libc
Copy link
Member

I think actually the wrong thing is the computation of how to split the instructions in columns. If I do pCd 2 i expect 2 rows, so the instructions should be correctly distributed over 2 rows. The current fix just displays an additional row, but it does not fix the actual issue.

@Codesbyusman
Copy link
Author

I think I messed this pull request. I am closing it and making a new one.

@Codesbyusman Codesbyusman deleted the pCd-missing-instructions branch March 28, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pCd missing instructions problems
2 participants