Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /wi by removing wrong fallthrough #3636

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fix /wi by removing wrong fallthrough #3636

merged 1 commit into from
Jul 4, 2023

Conversation

ret2libc
Copy link
Member

@ret2libc ret2libc commented Jul 4, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

/wi was falling through the switch case and it was not accepting the input correctly. Fix this by breaking at the end of the '/w' case so that the search can begin.

Test plan

See test.

Closing issues

Closes #3633

/wi was falling through the switch case and it was not accepting the
input correctly. Fix this by breaking at the end of the '/w' case so
that the search can begin.
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should finish conversion to rzshell: #2212

@XVilka
Copy link
Member

XVilka commented Jul 4, 2023

Just for the record, btw, this kind of search should employ the string search from librz/include/rz_util/rz_str_search.h cc @wargio, because librz/search/keyword.c seems to reimplement the thing again...

@XVilka XVilka merged commit 194eaba into dev Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/wi doesn't work
2 participants