Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Mark the bytes that is referenced as data and not belonging to any fu… #3804

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Aug 28, 2023

…nction

  • add flag space xdata to label these data
  • show hex instead of invalid for labeled position

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

I will solve failed tests later.

Test plan

...

Closing issues

closes #3641

librz/core/disasm.c Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the API label Sep 3, 2023
@PeiweiHu PeiweiHu marked this pull request as ready for review September 3, 2023 03:07
* \brief Mark the bytes that are referenced and don't belong
* to any functions as data.
*/
static void core_analysis_referenced_data(RzCore *core) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a command to run this analysis manually. (subcommand under aa).

Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests.

@PeiweiHu PeiweiHu closed this Sep 10, 2023
@XVilka
Copy link
Member

XVilka commented Sep 11, 2023

@PeiweiHu why close this?

@PeiweiHu
Copy link
Contributor Author

@PeiweiHu why close this?

I am sorry. Just too busy these days to complete this and worry my PR will hinder other contributors who wanna give it a try about this issue. I will take over this again when have more free time if this issue is still not solved. Sorry again.

@XVilka
Copy link
Member

XVilka commented Jan 21, 2024

@PeiweiHu why close this?

I am sorry. Just too busy these days to complete this and worry my PR will hinder other contributors who wanna give it a try about this issue. I will take over this again when have more free time if this issue is still not solved. Sorry again.

No one has taken this issue since 🤣

@PeiweiHu PeiweiHu reopened this May 16, 2024
@PeiweiHu PeiweiHu marked this pull request as draft May 16, 2024 09:28
@XVilka
Copy link
Member

XVilka commented Jul 11, 2024

@PeiweiHu hi, have you had a chance to finish this one?

@PeiweiHu
Copy link
Contributor Author

@PeiweiHu hi, have you had a chance to finish this one?

@XVilka Hi, I've been quite preoccupied with the submission of a new research paper for the past couple of months, which may have left me with insufficient time to handle this PR. I have no objections to anyone interested in directly adopting this PR to address the corresponding issue if it is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark bytes as data and show as such in disassembly if referenced as DATA
3 participants