Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the analysis_global_var test when running from the build dir. #3826

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

arrowd
Copy link
Contributor

@arrowd arrowd commented Sep 3, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Without this change the analysis_global_var test fails with

test_rz_analysis_global_var ERR
[XX] Fail at line 51: get global var by addr: expected to not be NULL but it was.

test_flag_confusion_space_name OK
test_flag_confusion_addr OK
test_flag_confusion_delete ERR
[XX] Fail at line 244: get global var by addr: expected to not be NULL but it was.

This PR continues the work from #3622

@XVilka XVilka added this to the 0.6.2 milestone Sep 5, 2023
@ret2libc ret2libc merged commit 08091e6 into rizinorg:dev Sep 12, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants