Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coloring help output of rizin,rz-diff,rz-asm #4046

Merged
merged 9 commits into from
Jan 8, 2024

Conversation

byteninjaa0
Copy link
Contributor

@byteninjaa0 byteninjaa0 commented Dec 25, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description
colored help output of rizin, rz-diff,rz-asm

...

Test plan

...

Closing issues

...
Screenshot 2023-12-25 134758
Screenshot 2023-12-25 013945

Screenshot 2023-12-25 121131

Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run clang format

@wargio
Copy link
Member

wargio commented Dec 25, 2023

be sure to run the correct clang format.

requires clang format 16 and then run ./sys/clang-format.py

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byteninjaa0 this PR contains a lot of unrelated changes, please remove those

@byteninjaa0
Copy link
Contributor Author

how to solve this conflicts

@XVilka
Copy link
Member

XVilka commented Jan 5, 2024

how to solve this conflicts

Just edit the file when rebasing.

@byteninjaa0 byteninjaa0 force-pushed the coloring_help_output branch from a6f4477 to eb47f71 Compare January 5, 2024 18:46
@byteninjaa0
Copy link
Contributor Author

i have run the clang-format-16 but to make the source code more cleaner i have formatted the help strings manually.

librz/core/cprint.c Outdated Show resolved Hide resolved
librz/include/rz_core.h Outdated Show resolved Hide resolved
@XVilka XVilka requested a review from wargio January 6, 2024 04:00
@byteninjaa0
Copy link
Contributor Author

i think the clang format check is failing because i have manually formatted the help string to maintain cleaner codebase
isn't it?

librz/include/rz_core.h Outdated Show resolved Hide resolved
librz/core/cprint.c Outdated Show resolved Hide resolved
librz/main/rz-diff.c Show resolved Hide resolved
@byteninjaa0 byteninjaa0 force-pushed the coloring_help_output branch from f6c65f6 to 13f17b9 Compare January 8, 2024 14:41
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the function and rebase on top of the latest dev. Apart from that LGTM.

librz/core/cprint.c Outdated Show resolved Hide resolved
librz/core/cprint.c Outdated Show resolved Hide resolved
@byteninjaa0 byteninjaa0 force-pushed the coloring_help_output branch from ba04ba1 to 53a5b83 Compare January 8, 2024 17:27
@github-actions github-actions bot added RzUtil and removed RzCore labels Jan 8, 2024
@XVilka XVilka merged commit 5c28709 into rizinorg:dev Jan 8, 2024
44 checks passed
@byteninjaa0 byteninjaa0 deleted the coloring_help_output branch January 14, 2024 17:01
@byteninjaa0 byteninjaa0 mentioned this pull request Jan 14, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants