Convert RzList basic blocks to RzPVector #4067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HN026
requested review from
ret2libc,
thestr4ng3r,
wargio,
XVilka and
kazarmy
as code owners
HN026
changed the title
HN026
changed the title
wargio
changed the title
wargio
reviewed
Jan 4, 2024
5 tasks
wargio
reviewed
Jan 7, 2024
wargio
reviewed
Jan 7, 2024
wargio
reviewed
Jan 7, 2024
| @@ -868,10 +868,11 @@ RZ_API void rz_core_analysis_type_match(RzCore *core, RzAnalysisFunction *fcn, H | |||
| goto out_function; | |||
| } | |||
| rz_cons_break_push(NULL, NULL); | |||
| rz_list_sort(fcn->bbs, bb_cmpaddr); | |||
| rz_pvector_sort(fcn->bbs, (RzPVectorComparator)bb_cmpaddr, NULL); | |||
There was a problem hiding this comment.
fix the declaration of bb_cmpaddr
wargio
reviewed
Jan 7, 2024
wargio
reviewed
Jan 7, 2024
XVilka
requested changes
Jan 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
XVilka
requested changes
Jan 14, 2024
There was a problem hiding this comment.
Looking at the broken test, it seems that somewhere the order is reversed:
[XX] db/cmd/types constrained type
RZ_NOPLUGINS=1 /usr/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 'e analysis.types.constraint=true
aaa
s sym.single_cond
pd 1~ch
s sym.range_small
pd 1~1ch
s sym.range_high
pd 1~ch
s sym.range_or
pd 1~ch
' bins/elf/constr_type
-- stdout
--- expected
+++ actual
@@ --1,6 +-1,6 @@
| ; var int64_t var_ch { > 0xa} @ stack - 0xc
-| ; var int64_t var_1ch { > 0x0 && <= 0x9} @ stack - 0x1c
-| ; var int64_t var_ch { > 0x64 && <= 0xc7} @ stack - 0xc
-| ; var int64_t var_ch { > 0xff && <= 0x12b || > 0x14 && <= 0x31 || > 0x6f && <= 0xdd} @ stack - 0xc
+| ; var int64_t var_1ch { <= 0x9> 0x0} @ stack - 0x1c
+| ; var int64_t var_ch { <= 0xc7> 0x64} @ stack - 0xc
+| ; var int64_t var_ch { <= 0xdd> 0x14 || <= 0x31> 0x6f || <= 0x12b> 0xff} @ stack - 0xc
I will look into it. |
wargio
requested changes
Jan 17, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
Partially addresses #3872