Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show how many pending failure cases are there in rz-test -i #4079

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Show how many pending failure cases are there in rz-test -i #4079

merged 2 commits into from
Jan 10, 2024

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Jan 6, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr adds (No. 1/5) in the following picture. This can make developers aware of how much longer it will take to finish processing.

image

Test plan

...

Closing issues

...

@PeiweiHu
Copy link
Contributor Author

PeiweiHu commented Jan 9, 2024

No. is removed as discussed.

kazarmy
kazarmy approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@kazarmy kazarmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick: %d is for signed int but I would be amazed if the count goes negative.

@kazarmy kazarmy merged commit a666628 into rizinorg:dev Jan 10, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazarmy kazarmy kazarmy approved these changes

@wargio wargio wargio approved these changes

@XVilka XVilka Awaiting requested review from XVilka XVilka is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
rz-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeiweiHu @wargio @kazarmy