Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sections in RzBinPlugin from list to pvector #4089

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Refactor sections in RzBinPlugin from list to pvector #4089

merged 2 commits into from
Jan 11, 2024

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Jan 9, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

CI is green.

Closing issues

partially address #3755
partially address #3775

XVilka
XVilka requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two small nitpicks

librz/util/vector.c Outdated Show resolved Hide resolved
librz/util/vector.c Outdated Show resolved Hide resolved
@XVilka XVilka added this to the 0.7.0 milestone Jan 10, 2024
@wargio wargio merged commit 3a2148e into rizinorg:dev Jan 11, 2024
44 checks passed
@kazarmy kazarmy mentioned this pull request Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka requested changes

@wargio wargio wargio approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API DEX ELF java Mach-O PE rizin rz-bin rz-diff rz-test RzAnalysis RzBin RzCore RzUtil
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PeiweiHu @XVilka @wargio