Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsigned numbers in i commands JSON output #4091

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Jan 10, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Before, PJ API was used to print signed integers where they are really unsigned (pj_kN vs pj_kn). Use unsigned for all addresses and sizes. Those structure members that are u64 also changed to print unsigned.

Test plan

CI is green

@XVilka XVilka added this to the 0.7.0 milestone Jan 10, 2024
@XVilka XVilka force-pushed the asan-fix-json-unsigned-numbers branch from 9fa0f8e to 75995fe Compare January 10, 2024 11:28
@XVilka XVilka force-pushed the asan-fix-json-unsigned-numbers branch from 75995fe to af6af66 Compare January 10, 2024 11:33
@XVilka
Copy link
Member Author

XVilka commented Jan 10, 2024

Ignore Muon CI job failure - it's network, SourceHut seems down.

@wargio
Copy link
Member

wargio commented Jan 10, 2024

Ignore Muon CI job failure - it's network, SourceHut seems down.

probably we should add muon zip to fallback

@XVilka XVilka merged commit d9c70f6 into dev Jan 10, 2024
46 of 47 checks passed
@XVilka XVilka deleted the asan-fix-json-unsigned-numbers branch January 10, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants