Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple POST-command and changed upload path (remote) #4106

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

deadshot8086
Copy link
Contributor

@deadshot8086 deadshot8086 commented Jan 14, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Closes #1897

XVilka

This comment was marked as resolved.

XVilka

This comment was marked as resolved.

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run export PATH=${HOME}/Library/Python/3.9/bin:${HOME}/Library/Python/3.10/bin:${HOME}/.local/bin:${PATH}
pylint: Command line or configuration file:1: UserWarning: 'BaseException' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.BaseException' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
pylint: Command line or configuration file:1: UserWarning: 'Exception' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.Exception' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
************* Module fuzz_rz_asm
test/fuzz/scripts/fuzz_rz_asm.py:137:11: E0601: Using variable 'sys' before assignment (used-before-assignment)

-----------------------------------
Your code has been rated at 9.94/10

Error: Process completed with exit code 123.

@deadshot8086 deadshot8086 force-pushed the http-post-cmd branch 2 times, most recently from 56d8832 to 961fd1b Compare January 16, 2024 05:50
librz/core/rtr_http.c Outdated Show resolved Hide resolved
librz/core/rtr_http.c Outdated Show resolved Hide resolved
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some comments that should be fixed. also if http.index is not used anywhere else, you can also do a cleanup and remove it from cconfig.c

remote files can be uploaded now via /upload/
commands now can be transmitted via POST body, because its not good to transmit special characters via URI path
should be enough to update rz-pipe in order to enable remote analysis
@deadshot8086
Copy link
Contributor Author

deadshot8086 commented Jan 16, 2024

LGTM just some comments that should be fixed. also if http.index is not used anywhere else, you can also do a cleanup and remove it from cconfig.c

ya it is used in remote get command in browser to display index.html when no cmd is specified, so can't remove it

@wargio wargio merged commit b82eadc into rizinorg:dev Jan 17, 2024
44 checks passed
@deadshot8086 deadshot8086 deleted the http-post-cmd branch January 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants