Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove globals in RzAsm plugins #4114

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Remove globals in RzAsm plugins #4114

merged 2 commits into from
Jan 17, 2024

Conversation

wargio
Copy link
Member

@wargio wargio commented Jan 16, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Cleanup to remove globals in RzAsm (including usage of sdb_fmt)

@wargio
Copy link
Member Author

wargio commented Jan 16, 2024

@Rot127 beware i did some changes.

XVilka
XVilka requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine but it breaks some tests

@XVilka XVilka requested review from imbillow and Rot127 January 16, 2024 14:22
@XVilka XVilka added this to the 0.7.0 milestone Jan 16, 2024
@wargio wargio requested a review from XVilka January 16, 2024 16:29
@XVilka XVilka merged commit 0b54b57 into dev Jan 17, 2024
46 of 47 checks passed
@XVilka XVilka deleted the remove-globals-asm branch January 17, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@imbillow imbillow Awaiting requested review from imbillow

@Rot127 Rot127 Awaiting requested review from Rot127

Assignees
No one assigned
Labels
ARM MIPS PPC X86
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wargio @XVilka