Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static buffer from dwarf code. #4117

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Remove static buffer from dwarf code. #4117

merged 2 commits into from
Jan 18, 2024

Conversation

wargio
Copy link
Member

@wargio wargio commented Jan 17, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

@wargio
Copy link
Member Author

wargio commented Jan 17, 2024

@imbillow please give a look

@wargio wargio closed this Jan 17, 2024
@wargio wargio reopened this Jan 17, 2024
@imbillow
Copy link
Contributor

@imbillow please give a look

Some tests are broken. rz_analysis_var_storage_init_reg uses const char*, which may also need to be changed to fit.

@wargio wargio force-pushed the remove-static-in-dwarf branch from 060da64 to 4a7e0f7 Compare January 17, 2024 13:42
@wargio wargio requested review from XVilka and kazarmy as code owners January 17, 2024 13:42
@github-actions github-actions bot added API and removed RzBin labels Jan 17, 2024
@XVilka XVilka merged commit 3b591e6 into dev Jan 18, 2024
45 of 47 checks passed
@XVilka XVilka deleted the remove-static-in-dwarf branch January 18, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbillow imbillow imbillow approved these changes

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API DWARF RzAnalysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wargio @imbillow @XVilka