Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$: Refactor out code for $* and $** #4368

Merged
merged 2 commits into from
Mar 17, 2024
Merged

$: Refactor out code for $* and $** #4368

merged 2 commits into from
Mar 17, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Mar 17, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr just refactors out the code for $* and $** into their own function.

Test plan

All builds are green.

Closing issues

Tracking issues: #1583, #1342

@kazarmy kazarmy merged commit 547732c into rizinorg:dev Mar 17, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
rz-test RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazarmy @XVilka