Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NE relocation naming #4725

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix NE relocation naming #4725

merged 2 commits into from
Nov 22, 2024

Conversation

Roeegg2
Copy link
Contributor

@Roeegg2 Roeegg2 commented Nov 20, 2024 •
edited by wargio
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Name NE relocations by combining src and flag
  • Fix old test + add additional tests

@Roeegg2 Roeegg2 marked this pull request as draft November 20, 2024 22:03
@Roeegg2
Copy link
Contributor Author

Roeegg2 commented Nov 20, 2024

The PR I opened on rizin-testbins needs to be merged before merging this, as some tests here use the new bins there

wargio
wargio reviewed Nov 21, 2024
View reviewed changes
librz/bin/format/ne/ne.c Outdated Show resolved Hide resolved
wargio
wargio reviewed Nov 21, 2024
View reviewed changes
test/db/formats/ne Outdated Show resolved Hide resolved
wargio
wargio reviewed Nov 21, 2024
View reviewed changes
librz/bin/format/ne/ne.c Outdated Show resolved Hide resolved
@Roeegg2
Fix NE relocation naming
c5d0f32 
* Name NE relocations by combining `src` and `flag`
* Fix old test + add additional tests
wargio
wargio reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct now.

@Roeegg2 Roeegg2 marked this pull request as ready for review November 22, 2024 02:36
wargio
wargio reviewed Nov 22, 2024
View reviewed changes
librz/bin/format/ne/ne.c Outdated Show resolved Hide resolved
wargio
wargio approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. i made a small change, once green i will merge.

@XVilka XVilka merged commit 2e5473b into rizinorg:dev Nov 22, 2024
45 checks passed
@Roeegg2 Roeegg2 deleted the ne-relocs branch December 3, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
merge-when-green rz-test RzBin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roeegg2 @XVilka @wargio