Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pj to RzShell #4726

Merged
merged 8 commits into from
Nov 24, 2024
Merged

Convert pj to RzShell #4726

merged 8 commits into from
Nov 24, 2024

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Nov 21, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Moves the pj command to RzShell. It also does some clean ups:

  • Removes pj., because it was an alias for pj @ 0
  • Removes pj.., because the JSON path function always returned NULL (never a valid value), and did not document what it does in the first place.
  • Print message for user if no valid data was found at address.
  • Change description of command to be more clear it only prints formatted JSON strings.
  • Removes unused size/len argument.
  • Adds a new test for pj.
  • Adds some general documentation how to implement or find a command.

Test plan

Added

Closing issues

None, but checks a box in #1590

@Rot127 Rot127 mentioned this pull request Nov 21, 2024
32 tasks
@Rot127 Rot127 changed the title Move pj to RzShell Convert pj to RzShell Nov 21, 2024
@Rot127 Rot127 changed the title Convert pj to RzShell Convert pj to RzShell Nov 21, 2024
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, with mostly documentation nitpicks

DEVELOPERS.md Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_print.yaml Outdated Show resolved Hide resolved
@XVilka XVilka merged commit be24ca8 into dev Nov 24, 2024
48 checks passed
@XVilka XVilka deleted the rzshell-pj branch November 24, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants