Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ae commands to RzShell #4732

Merged
merged 19 commits into from
Nov 26, 2024
Merged

Port ae commands to RzShell #4732

merged 19 commits into from
Nov 26, 2024

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Nov 23, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Port the ae commands to RzShell.

Remove

  • ae* - It was marked as not working and had no direct advantage. With the transition to RzIL it becomes obsolete.

To RzShell, but remove with ESIL

  • aepc
  • ae
  • ae??
  • aex

To RzShell, but port to RzIL

  • aeb
  • aef
  • aefa
  • aeA
  • aea
  • aeab
  • aeafj
  • aeafj
  • aeab
  • aeabj

To RzShell, but reimplement

  • aek
  • aek-
  • aeli
  • aeli
  • aelir

Last

  • Remove a* (doesn't work)
  • Remove legacy rz_cmd_analysis handler + fixup in yaml files.

Test plan

All green

Closing issues

closes #1533

@Rot127 Rot127 marked this pull request as draft November 23, 2024 18:51
@Rot127 Rot127 changed the title Port ae command to RzShell Port ae commands to RzShell Nov 23, 2024
@Rot127 Rot127 added this to the 0.8.0 milestone Nov 23, 2024
@Rot127 Rot127 mentioned this pull request Nov 23, 2024
Closed
5 tasks
XVilka
XVilka requested changes Nov 24, 2024
View reviewed changes
librz/core/cmd_descs/cmd_analysis.yaml Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_analysis.yaml Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_analysis.yaml Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_analysis.yaml Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_analysis.yaml Outdated Show resolved Hide resolved
librz/core/cmd/cmd_analysis.c Show resolved Hide resolved
@Rot127
Fix ae tests by putting expressions in strings.
4aef0bd 
They contain special/illegal argument characters for the RzShell.
@Rot127
Fix parameter order of aea command.
e59725c 
For the most common case people just pass a number.
Hence, it must be the first argument.
@Rot127
Run yamllint
f0201ea
@Rot127 Rot127 marked this pull request as ready for review November 24, 2024 19:26
@Rot127 Rot127 mentioned this pull request Nov 24, 2024
Open
24 tasks
@wargio wargio merged commit 7b2737f into dev Nov 26, 2024
46 checks passed
@wargio wargio deleted the rzshell-ae branch November 26, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka XVilka approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees

@wargio wargio

Labels
rz-test RzCore
Projects
RzShell improvements
Status: Done
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Migrate ae commands to the rzshell
3 participants
@Rot127 @XVilka @wargio