Add / (search) commands to newshell + rewrite of rz_search #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
RzAnalysis
rz-find
API
RzCore
ARM
MIPS
PPC
X86
RzUtil
RzSearch
labels
Rot127
reviewed
Nov 25, 2024
| RZ_API void rz_search_collection_free(RZ_NULLABLE RzSearchCollection *sc); | ||
| RZ_API void rz_search_hit_free(RZ_NULLABLE RzSearchHit *hit); | ||
|
|
||
| RZ_API RZ_OWN RzList /*<RzSearchHit *>*/ *rz_search_run(RZ_NONNULL RzSearchOpt *opt, RZ_NONNULL RzSearchCollection *col, RZ_NONNULL RzIO *io, RZ_NONNULL RzList /*<RzIOMap *>*/ *search_in); |
There was a problem hiding this comment.
Maybe changing the search_in parameter to void * and infer the type based on some flag in opt. This way we can use this function later to search other things then IO.
There was a problem hiding this comment.
Not so sure about this, but maybe.
Rot127
reviewed
Nov 25, 2024
Rot127
reviewed
Nov 25, 2024
Rot127
reviewed
Nov 25, 2024
Rot127
reviewed
Nov 25, 2024
Rot127
reviewed
Nov 25, 2024
Rot127
reviewed
Nov 25, 2024
wargio
force-pushed
the
fuzz-dist-cmd-search
branch
from
2123d77 to
9b1253f
Compare
XVilka
requested changes
Nov 30, 2024
| // SPDX-FileCopyrightText: 2008 J. Alex Halderman | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| // Originally from RSAKeyFinder 1.0 (2008-07-18) By Nadia Heninger and J. Alex Halderman |
| { 0x02, 0x01, 0x00, 0x30 }, | ||
| }; | ||
|
|
||
| /*Baby BER parser, just good enough for private keys. |
There was a problem hiding this comment.
Since there is comment already for this function , maybe convert to Doxygen?
There was a problem hiding this comment.
this comment is actually wrong. the code is looking for DER encoding, but i will fix this once it will be "ready"
| return start + 2 + lensize; | ||
| } | ||
|
|
||
| /* Check if `start` points to an ensemble of BER fields |
| return true; | ||
| } | ||
|
|
||
| // Finds and return index of a private key based on the asn1 bytes |
|
|
||
| #include <rz_search.h> | ||
| #include <rz_util.h> | ||
|
|
There was a problem hiding this comment.
Please add \file to note that it searches not only ANSI/ASCII but also Unicode and some other encodings
wargio
force-pushed
the
fuzz-dist-cmd-search
branch
from
9b1253f to
03c4c7b
Compare
This was referenced Dec 10, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This is a complete rewrite of the legacy code which is too complicated to import into new-shell.
The goal is to refactor
rz_searchand implement the search command properly using pre-existing code like search of strings via rz_utils and more.closes #1909