Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port v and V to RzShell #4745

Merged
merged 8 commits into from
Nov 28, 2024
Merged

Port v and V to RzShell #4745

merged 8 commits into from
Nov 28, 2024

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Nov 26, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This brings some changes:

  • Visual commands passed to V, must be given as normal argument (space between command and string).
  • Changes "load layout" v [layout-name] to vl [layout-name], to have a hard distinction between v and vl.
  • Change "store layout" v= [layout-name] tp vs [layout-name]. Because it is more descriptive and matches vl a little better.
  • Drops the vi command for two reasons:
    • vi (open file in editor) is not at all related to the visual mode. Hence shouldn't be in the same group.
    • (Opinionated) Users can just open the file in another terminal window. Why go the extra way over Rizin?

Test plan

All green

Closing issues

...

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my practice, commands like Vp, Vpp, and VP are common, maybe add some aliases for those particular cases?

librz/core/cmd_descs/cmd_interactive.yaml Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_interactive.yaml Outdated Show resolved Hide resolved
@Rot127 Rot127 requested a review from XVilka November 27, 2024 17:03
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm ok with these.

@XVilka

This comment was marked as resolved.

Drops the vi command for two reasons:

- vi (open file in editor) is not at all related to the visual mode.
Hence shouldn't be in the same group.
- (Opinionated) Users can just open the file in another
terminal window. Why go the extra way over Rizin?

Replace old command names with something more descriptive.

- v [name] -> vl name
- v= -> vs
Add VH and VHH for key list in the visual mode.
Remove examples, but add a more detailed description about the key-sequence parameter.
@XVilka XVilka merged commit db97112 into rizinorg:dev Nov 28, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants