-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port v
and V
to RzShell
#4745
Merged
Merged
Port v
and V
to RzShell
#4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested review from
wargio,
XVilka,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
November 26, 2024 18:44
23 tasks
wargio
approved these changes
Nov 27, 2024
XVilka
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my practice, commands like Vp
, Vpp
, and VP
are common, maybe add some aliases for those particular cases?
XVilka
requested changes
Nov 27, 2024
Rot127
force-pushed
the
rzshell-visual
branch
from
November 27, 2024 17:05
306781e
to
53a3e52
Compare
XVilka
approved these changes
Nov 27, 2024
wargio
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm ok with these.
Rot127
force-pushed
the
rzshell-visual
branch
from
November 28, 2024 13:01
53a3e52
to
dce4b09
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Drops the vi command for two reasons: - vi (open file in editor) is not at all related to the visual mode. Hence shouldn't be in the same group. - (Opinionated) Users can just open the file in another terminal window. Why go the extra way over Rizin? Replace old command names with something more descriptive. - v [name] -> vl name - v= -> vs
Add VH and VHH for key list in the visual mode. Remove examples, but add a more detailed description about the key-sequence parameter.
Rot127
force-pushed
the
rzshell-visual
branch
from
November 28, 2024 13:17
dce4b09
to
03a1e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This brings some changes:
V
, must be given as normal argument (space between command and string).v [layout-name]
tovl [layout-name]
, to have a hard distinction betweenv
andvl
.v= [layout-name]
tpvs [layout-name]
. Because it is more descriptive and matchesvl
a little better.Test plan
All green
Closing issues
...