Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port k commands to RzShell #4747

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Port k commands to RzShell #4747

merged 3 commits into from
Nov 28, 2024

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Nov 27, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Ports the k commands to RzShell.
Please note, the kd command doesn't work as expected. Dumping the sdb to a file seems to continue writing to it afterwards.
But it doesn't seem too useful to fix it. Also dumping to file.sdb doesn't write a file at all.
It doesn't seem useful to me fixing it currently.

Test plan

Added

Closing issues

...

@XVilka XVilka merged commit f1b99c9 into rizinorg:dev Nov 28, 2024
44 checks passed
@Rot127 Rot127 deleted the rzshell-k branch November 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants