Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :? #4793

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Fix :? #4793

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a3efd8
Fix `:?`
kazarmy Dec 25, 2024
3922da1
Be more precise with list notation
kazarmy Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions librz/core/cmd_descs/cmd_descs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19195,7 +19195,7 @@ static const RzCmdDescHelp grep_help = {
static const RzCmdDescDetailEntry specifiers_Table_space_format_space_specifiers_space__oparen__minor_table_spec_greater__cparen__detail_entries[] = {
{ .text = "<col>/sort/<inc|dec>", .arg_str = NULL, .comment = "Sort table by column <col> in increasing or decreasing order." },
{ .text = "<col>/sortlen/<inc|dec>", .arg_str = NULL, .comment = "Sort table length of column <col> in increasing or decreasing order." },
{ .text = "<col>/cols[/<col2>[/<colN>...]", .arg_str = NULL, .comment = "Show only specified columns in the table." },
{ .text = "<col>/cols[/<col2>/<col3>...]", .arg_str = NULL, .comment = "Show only specified columns in the table." },
{ .text = "<col>", .arg_str = NULL, .comment = "Show only column <col> (it must not have the same name as an output format specifier)." },
{ .text = "<col>/gt/<val>", .arg_str = NULL, .comment = "Grep rows where column <col> is greater than <val>." },
{ .text = "<col>/ge/<val>", .arg_str = NULL, .comment = "Grep rows where column <col> is greater than or equal to <val>." },
Expand Down Expand Up @@ -19236,7 +19236,7 @@ static const RzCmdDescDetail specifiers_details[] = {
};
static const RzCmdDescHelp specifiers_help = {
.summary = "Command specifiers (table-output only for now)",
.usage = "<command>[:<table_spec>[:<table_spec>:...]:<output_spec>]",
.usage = "<command>[:<table_spec>:<table_spec>...][:<output_spec>]",
.options = "[?]",
.details = specifiers_details,
};
Expand Down
4 changes: 2 additions & 2 deletions librz/core/cmd_descs/cmd_descs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,15 +564,15 @@ commands:
options: "[?]"
summary: Command specifiers (table-output only for now)
type: RZ_CMD_DESC_TYPE_FAKE
usage: "<command>[:<table_spec>[:<table_spec>:...]:<output_spec>]"
usage: "<command>[:<table_spec>:<table_spec>...][:<output_spec>]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mark the optionality of the the second <table_spec>?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, one can be more precise with the brackets 3922da1

details:
- name: Table format specifiers (<table_spec>)
entries:
- text: "<col>/sort/<inc|dec>"
comment: Sort table by column <col> in increasing or decreasing order.
- text: "<col>/sortlen/<inc|dec>"
comment: Sort table length of column <col> in increasing or decreasing order.
- text: "<col>/cols[/<col2>[/<colN>...]"
- text: "<col>/cols[/<col2>/<col3>...]"
comment: Show only specified columns in the table.
- text: "<col>"
comment: Show only column <col> (it must not have the same name as an output format specifier).
Expand Down
Loading