Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PowerPC LI & LIS instructions #4800

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Fix PowerPC LI & LIS instructions #4800

merged 1 commit into from
Dec 28, 2024

Conversation

wargio
Copy link
Member

@wargio wargio commented Dec 28, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Capstone next does support PPC_INS_LI and PPC_INS_LIS

@wargio wargio changed the title Fix capstone next build for PowerPC Fix PowerPC LI & LIS instructions Dec 28, 2024
@wargio
Copy link
Member Author

wargio commented Dec 28, 2024

failures are unrelated to this PR (see dev branch)

@wargio wargio merged commit e536f85 into dev Dec 28, 2024
18 of 22 checks passed
@wargio wargio deleted the fix-ppc branch December 28, 2024 10:24
@Rot127
Copy link
Member

Rot127 commented Dec 28, 2024

Damn, those are bugs. They should be alias.
Do you still have the bytes which triggered them?

@wargio
Copy link
Member Author

wargio commented Dec 28, 2024

Damn, those are bugs. They should be alias. Do you still have the bytes which triggered them?

Those are not actual bugs, before the last update (when i was working on a newer version of capstone compared to dev) the RzIL ppc test was failing to detect the LI/LIS instructions because of that.

Now the alias exists and can be kept outside the #if #endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants