Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XTENSA Always fallback on bad CPU and set illegal on bad decoding #4801

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

wargio
Copy link
Member

@wargio wargio commented Dec 28, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Fixes the wrong internal logic and enforces illegal on fail decoding.

@wargio wargio changed the title Always fallback on default XTENSA on bad CPU XTENSA Always fallback on bad CPU and set illegal on fail decoding Dec 28, 2024
@wargio wargio changed the title XTENSA Always fallback on bad CPU and set illegal on fail decoding XTENSA Always fallback on bad CPU and set illegal on bad decoding Dec 28, 2024
@wargio
Copy link
Member Author

wargio commented Dec 28, 2024

failures are unrelated to this PR (see dev branch)

@XVilka XVilka merged commit b8dabe2 into dev Dec 28, 2024
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants