Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model span when printing regarima #136

Closed
wants to merge 6 commits into from

Conversation

TanguyBarthelemy
Copy link
Contributor

No description provided.

@AQLT
Copy link
Collaborator

AQLT commented Feb 21, 2024

Why do you want to add the model span to the print method?

@TanguyBarthelemy
Copy link
Contributor Author

This information is missing in the current print. But it could be very useful to the user to specify what the span is and remind (if the user has forgotten this information) that there is one.
Why not include this information?

@AQLT
Copy link
Collaborator

AQLT commented Feb 21, 2024

The information is already in the summary print method. The print method is supposed to be "simplified" (even if I think we should remove some statistics to have a very simple output) and the summary provides a more detailed output. Most of the time it will be redundant with the series span of the input time series. Moreover it is not printed in other seasonal adjustment / time series model packages.
So why do you think it is not enough to have it printed in the summary method?

@TanguyBarthelemy
Copy link
Contributor Author

TanguyBarthelemy commented Feb 22, 2024

Ok, I'll discuss it with @annasmyk. But I find that it may be a little difficult and twisted to find this information like that (you have to call another function with only the regarima part of your sai (summary(sai) doesn't return anything).

Thank you for your answer and your precision (I forgot the summary function...)

@AQLT
Copy link
Collaborator

AQLT commented Feb 22, 2024

So maybe we should implement a summary.SA() function which would only run the summary(object$regarima)?

@TanguyBarthelemy
Copy link
Contributor Author

Yes maybe, but I think that this information is quite important and that it would be better if it appeared in the print.
For now I will put my PR aside in this case.

@annasmyk
Copy link
Member

I would be strongly in favor of it appearing in the print as well..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants