Hotfix/fix mode station optimization #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut_path is of type Path
Reduce log level to differentiate between erros and infos
…x_mode_station_optimization
stefansc1
approved these changes
Oct 30, 2024
| @@ -171,7 +171,7 @@ def run_optimization(conf, sched=None, scen=None, args=None): | |||
| # rotations itself. | |||
| rotations_for_opt = optimizer.schedule.rotations.copy() | |||
|
|
|||
| logger.log(msg="Starting greedy station optimization", level=100) | |||
| logger.log(msg="Starting greedy station optimization", level=39) | |||
There was a problem hiding this comment.
maybe use a more verbose level? Like logging.WARN?
There was a problem hiding this comment.
my thinking was, to not use warn since it might be misleading. Its more like a "mandatory information"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecated variable_name optimizer_config to optimizer_config_path
Added Test for several untested modes.
Fix issue in StationOptimization with timesteps which are not 1 minute
Reduce log level of Simulation states just below the level of logging.ERROR