Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in replacement cost calculation reinvest in project last year #966

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

Bachibouzouk
Copy link
Collaborator

@Bachibouzouk Bachibouzouk commented Sep 25, 2023

Changes proposed in this pull request:

  • The test test_c2_economic_functions.py::test_get_replacement_costs_one_reinvestment_age_asset_equal_asset_lifetime was added to account for a field usecase and a solution was provided

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@Bachibouzouk Bachibouzouk force-pushed the fix/cost-calculation-reinvest-in-project-last-year branch from f2b665d to 8ed81f0 Compare September 25, 2023 13:55
@Bachibouzouk Bachibouzouk marked this pull request as ready for review September 25, 2023 13:55
@Bachibouzouk
Copy link
Collaborator Author

@ciaradunks - the test fail due to new pandas version, I will pin it an repush

@Bachibouzouk Bachibouzouk force-pushed the fix/cost-calculation-reinvest-in-project-last-year branch from f3ad09b to f0847cc Compare April 27, 2024 21:00
@Bachibouzouk Bachibouzouk force-pushed the fix/cost-calculation-reinvest-in-project-last-year branch from f0847cc to 39dfd4d Compare April 27, 2024 21:04
@Bachibouzouk Bachibouzouk merged commit 3a2b194 into dev Apr 27, 2024
0 of 2 checks passed
@Bachibouzouk Bachibouzouk deleted the fix/cost-calculation-reinvest-in-project-last-year branch April 27, 2024 21:07
@Bachibouzouk Bachibouzouk mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants