Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
improved pv_panel based on the findings from PR#49 feature/test_pv:
as described in PR#49 feature/test_pv:
in any case, the peak capacity could be accessed directly from the facades
for pv_panel.py:
the variable "modules_per_m2" can be multiplied by pv_params["p_rated"] to get Wp/m² and eventually the capacity in m² (from pv_panel converter or source) to get Wp
for apv.py:
geo_params["kwp"]
Type of change (CHANGELOG.md)
Added
Changed
Removed
Workflow checklist
Automation
Closes #
PR-Assignee
Reviewer