Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated pv_panel and apv facade #51

Merged
merged 1 commit into from
Oct 29, 2024
Merged

updated pv_panel and apv facade #51

merged 1 commit into from
Oct 29, 2024

Conversation

MaaJoo13
Copy link
Collaborator

Summary of the discussion

improved pv_panel based on the findings from PR#49 feature/test_pv:

  • updated pv parameters in global_specs/pv_modules.py
  • pv_panel efficiency updated by taking in the parameters "modules_per_m²" and "ghi_to_gni"
  • updated pv parameters and ghi_to_gni are also used for the apv facade to correct the output
  • function restructuring within the facades and linting

as described in PR#49 feature/test_pv:

  • pv_panel capacity can be linked to source (will be m²) or kept openly expandable (will be kW)
  • pv_panel capacity in m² is problematic if output higher than 1 kW/m² (capacity of 100 can not produce more than 100)
  • pv_panel capacity in kW is problematic because the real peak capacity is usually higher than the optimized capacity (which is just the maximum power output within the provided time series)

in any case, the peak capacity could be accessed directly from the facades

for pv_panel.py:
the variable "modules_per_m2" can be multiplied by pv_params["p_rated"] to get Wp/m² and eventually the capacity in m² (from pv_panel converter or source) to get Wp

for apv.py:
geo_params["kwp"]

Type of change (CHANGELOG.md)

Added

  • Add a new class (#)

Changed

  • Update a definition (#)

Removed

  • Remove a broken link (#)

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

Copy link
Contributor

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaaJoo13 !

@Bachibouzouk Bachibouzouk merged commit e00531e into production Oct 29, 2024
1 check passed
@Bachibouzouk Bachibouzouk deleted the feature/pv branch October 29, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants