Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Make your shitty code more readable #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BronsonQuick
Copy link

Do you even code bro?

@dd32
Copy link

dd32 commented Jul 12, 2017

Step in the right direction, but to ensure readability standards are complied with the escaped \" should be converted into ' in the <a> tag.

Tags: needs-refresh

@stuartshields
Copy link

LGTM, let's merge this bad boy in pending @dd32 comment.

@@ -15,25 +15,25 @@ class OPML {
var $template_file;
var $_links = array();

function OPML($file) {
function OPML( $file ) {
$this->file = $file;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many spaces

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could say, not enough spaces 🤔

foreach($d_ar as $element) {
if($element['tag'] == 'OUTLINE') {
foreach( $d_ar as $element ) {
if( $element['tag'] == 'OUTLINE' ) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yoda

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants