Limit accepted name lengths in identity class

rmhdev · Jan 9, 2016 · 0a7edba · 0a7edba
1 parent f23d890
commit 0a7edba
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/Identicon/Identity/Identity.php b/src/Identicon/Identity/Identity.php
@@ -7,6 +7,8 @@
 
 final class Identity
 {
+    const MAX_LENGTH = 255;
+
     private $name;
     private $options;
     private $hash;
@@ -43,7 +45,13 @@ private function processLength($length)
 
     private function initializeIdentification($identification)
     {
-        $this->name = mb_convert_case($identification, MB_CASE_LOWER, "UTF-8");
+        $name = mb_convert_case($identification, MB_CASE_LOWER, "UTF-8");
+        if (self::MAX_LENGTH < mb_strlen($name)) {
+            throw new OutOfBoundsException(
+                sprintf('Identity name is too long (%d), max is %d', mb_strlen($name), self::MAX_LENGTH)
+            );
+        }
+        $this->name = $name;
         $this->hash = sha1($this->name);
     }
 

diff --git a/tests/Identicon/Tests/Identity/IdentityTest.php b/tests/Identicon/Tests/Identity/IdentityTest.php
@@ -31,7 +31,7 @@ public function testIdentityCustomizedLength()
      */
     public function testLengthOutOfBoundsException($length)
     {
-        $identity = new Identity("name", array("length" => $length));
+        new Identity("name", array("length" => $length));
     }
 
     public function lengthOutOfBoundsProvider()
@@ -184,4 +184,11 @@ public function testGetName()
         $this->assertEquals("idëntificaçióñ", $identityComplex->getName());
     }
 
+    /**
+     * @expectedException Identicon\Exception\OutOfBoundsException
+     */
+    public function testTooLongNameShouldThrowException()
+    {
+        new Identity(str_repeat("abcdefghij", 25) . "123456");
+    }
 }