Use frozen string literals and regex constants to reduce allocations #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing operations on lots of models, strip_attributes can be responsible for a lot of small allocations for strings and regexes that do not change, but are nonetheless re-allocated every time a model is saved. Across thousands of records, this is a sizeable chunk of memory. Luckily, since the strings and regexes do not change, we can mark them as frozen and/or reference them via constants to avoid allocating them more than once.
rmm5t
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing operations on lots of models, strip_attributes can be responsible for a lot
of small allocations for strings and regexes that do not change, but are nonetheless
re-allocated every time a model is saved. Across thousands of records, this is a sizeable
chunk of memory. Luckily, since the strings and regexes do not change, we can mark them as
frozen and/or reference them via constants to avoid allocating them more than once.