Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post_type url parameter #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

post_type url parameter #11

wants to merge 1 commit into from

Conversation

hiro288
Copy link

@hiro288 hiro288 commented Jan 15, 2015

fixed post_type url parameter

fixed post_type url parameter
@rmorse
Copy link
Owner

rmorse commented Jan 15, 2015

Hey @naeemnur I'm afraid this is incorrect. The post_type parameter is native WordPress - so will work anywhere - however it only takes one argument. I implemented post_types so that we can pass multiple post types to it - eg post_types=post,page :)

@rmorse rmorse closed this Jan 15, 2015
@hiro288
Copy link
Author

hiro288 commented Jan 15, 2015

but it doesnt seems to work when you set 1 cpt

@rmorse
Copy link
Owner

rmorse commented Jan 15, 2015

Hmm I don't recall this being the case but I'll take a look - the change you have made above does effectively remove support for multiple post types - so the solution would be to fix post_types to also work with a single post type rather than switching it all over to use post_type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants