Skip to content

Commit

Permalink
fix(docs-infra): removal of the use of the ChildNode.remove() method …
Browse files Browse the repository at this point in the history
…that it isn't supported by IE (angular#28188)

fixes angular#28177

PR Close angular#28188
  • Loading branch information
wKoza authored and alxhub committed Jan 22, 2019
1 parent 0b6eaca commit 351ef2a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 3 additions & 2 deletions aio/src/app/layout/doc-viewer/doc-viewer.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,10 @@ export class DocViewerComponent implements OnDestroy {
if (needsToc && !embeddedToc) {
// Add an embedded ToC if it's needed and there isn't one in the content already.
titleEl!.insertAdjacentHTML('afterend', '<aio-toc class="embedded"></aio-toc>');
} else if (!needsToc && embeddedToc) {
} else if (!needsToc && embeddedToc && embeddedToc.parentNode !== null) {
// Remove the embedded Toc if it's there and not needed.
embeddedToc.remove();
// We cannot use ChildNode.remove() because of IE11
embeddedToc.parentNode.removeChild(embeddedToc);
}

return () => {
Expand Down
5 changes: 4 additions & 1 deletion aio/src/app/shared/toc.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ export class TocService {
}
}
// now remove the anchor
anchorLink.remove();
if (anchorLink.parentNode !== null) {
// We cannot use ChildNode.remove() because of IE11
anchorLink.parentNode.removeChild(anchorLink);
}
}
// security: the document element which provides this heading content
// is always authored by the documentation team and is considered to be safe
Expand Down

0 comments on commit 351ef2a

Please sign in to comment.